Skip to content

Commit fe483a6

Browse files
committed
Merge pull request microsoft#7326 from RyanCavanaugh/fix4577
Show aliases (e.g. imports) in JSX tag completion positions
2 parents 1e2d477 + 6cdbc6c commit fe483a6

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

src/services/services.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3134,7 +3134,7 @@ namespace ts {
31343134
else if (isRightOfOpenTag) {
31353135
const tagSymbols = typeChecker.getJsxIntrinsicTagNames();
31363136
if (tryGetGlobalSymbols()) {
3137-
symbols = tagSymbols.concat(symbols.filter(s => !!(s.flags & SymbolFlags.Value)));
3137+
symbols = tagSymbols.concat(symbols.filter(s => !!(s.flags & (SymbolFlags.Value | SymbolFlags.Alias))));
31383138
}
31393139
else {
31403140
symbols = tagSymbols;
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
/// <reference path='fourslash.ts' />
2+
3+
//@module: commonjs
4+
//@jsx: preserve
5+
6+
//@Filename: exporter.tsx
7+
//// export class Thing { }
8+
9+
//@Filename: file.tsx
10+
//// import {Thing} from './exporter';
11+
//// var x1 = <div></**/
12+
13+
goTo.marker();
14+
verify.completionListContains('Thing');

0 commit comments

Comments
 (0)