Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projections Reader: Minor Fixes #126

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Projections Reader: Minor Fixes #126

merged 2 commits into from
Oct 18, 2024

Conversation

adityaranjan
Copy link
Collaborator

  • resolves issue where reader would crash if entry method name had spaces
  • "Destination" was spelled incorrectly
  • "Receive" was spelled incorrectly

@adityaranjan adityaranjan added this to the Pipit release v0.1.0 milestone Apr 22, 2024
zoreoo
zoreoo approved these changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@zoreoo zoreoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be able to be merged

@zoreoo zoreoo mentioned this pull request Sep 22, 2024
Open
@movsesyanae movsesyanae removed the request for review from bhatele October 13, 2024 23:29
@movsesyanae movsesyanae merged commit 05d9563 into develop Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoreoo zoreoo zoreoo approved these changes

@movsesyanae movsesyanae movsesyanae approved these changes

Assignees
No one assigned
Labels
priority: urgent status: ready for review
Projects
None yet
Milestone
Pipit release v0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adityaranjan @movsesyanae @zoreoo