Skip to content

Commit 7feb9e8

Browse files
authored
Merge pull request #14 from hpc4cmb/docker_ld
Remove sourcing of cmbenv in docker entrypoint.
2 parents 9352d13 + 88b8242 commit 7feb9e8

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

pkgs/mpich.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ cleanup=""
66

77
version=3.4
88
pfile=mpich-${version}.tar.gz
9-
src=$(eval "@TOP_DIR@/tools/fetch_check.sh" http://www.mpich.org/static/downloads/${version}/${pfile} ${pfile})
9+
src=$(eval "@TOP_DIR@/tools/fetch_check.sh" https://www.mpich.org/static/downloads/${version}/${pfile} ${pfile})
1010

1111
if [ "x${src}" = "x" ]; then
1212
echo "Failed to fetch ${pkg}" >&2

pkgs/zlib.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ pkg="zlib"
44
pkgopts=$@
55
cleanup=""
66

7-
version=1.2.11
7+
version=1.2.12
88
pfile=zlib-${version}.tar.gz
9-
src=$(eval "@TOP_DIR@/tools/fetch_check.sh" http://zlib.net/${pfile} ${pfile})
9+
src=$(eval "@TOP_DIR@/tools/fetch_check.sh" https://zlib.net/${pfile} ${pfile})
1010

1111
if [ "x${src}" = "x" ]; then
1212
echo "Failed to fetch ${pkg}" >&2
@@ -26,7 +26,7 @@ rm -rf zlib-${version}
2626
tar xzf ${src} \
2727
&& cd zlib-${version} \
2828
&& cleanup="${cleanup} $(pwd)" \
29-
&& CC="@BUILD_CC@" ./configure \
29+
&& CC="@BUILD_CC@" CFLAGS="-O3 -fPIC" ./configure \
3030
--shared --prefix="@AUX_PREFIX@" > ${log} 2>&1 \
3131
&& make -j @MAKEJ@ >> ${log} 2>&1 \
3232
&& make install >> ${log} 2>&1

tools/docker-entrypoint.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ _is_sourced() {
3434
# Loads various settings that are used elsewhere in the script
3535
# This should be called before any other functions
3636
docker_setup_env() {
37-
source cmbenv
37+
# Our docker builds install to /usr/local, so this is
38+
# not needed. In fact, it can cause problems since the
39+
# setup script will manipulate LD_LIBRARY_PATH.
40+
#source cmbenv
41+
echo "" > /dev/null
3842
}
3943

4044
_main() {

0 commit comments

Comments
 (0)