Skip to content

🐛 Post 7.0 fixes #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2023
Merged

🐛 Post 7.0 fixes #873

merged 4 commits into from
Feb 27, 2023

Conversation

jrolfs
Copy link
Collaborator

@jrolfs jrolfs commented Feb 27, 2023

  • Update api/commit type definitions to reflect optional options in ls.dirs
  • Prevent commitlint from ever type-checking configuration
  • Ensure ts-jest escape hatch works with latest version of ts-jest
  • Update Jest documentation to reflect new default @swc-node/jest transform

…onfiguration

**@commitlint/cli** added support for TypeScript-based configurations via `ts-node`, and that has caused a good deal of grief:

conventional-changelog/commitlint#3420
conventional-changelog/commitlint#3351
conventional-changelog/commitlint#3218
conventional-changelog/commitlint#3256

hoverinc/web-react#1792

Both because it's a heavy-ass dependency and because it requires configuration to
work properly. It seems like project-local configuration can affect it's invocation
of ts-node, which happens even JavaScript configuration files now?... lame.

Anyways, this ensures we avoid any type-checking that happens in it's ts-node
invocation until we get a better solution upstream (or contribute one). Ideally,
installing ts-node would be opt-in etc.
@jrolfs jrolfs requested a review from jarrodplacide February 27, 2023 22:23
@jrolfs jrolfs merged commit 567aaf9 into main Feb 27, 2023
@jrolfs jrolfs deleted the fix/post-seven-dot-oh branch February 27, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant