Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kan 84/tab name #39

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Kan 84/tab name #39

merged 2 commits into from
Oct 9, 2024

Conversation

dh-giang-vu
Copy link
Collaborator

@dh-giang-vu dh-giang-vu commented Oct 8, 2024 •
edited
Loading

  1. Tab name should be "Timetabling for VIT"
  2. Tab logo should be VIT logo

Before:
kan-84-og
After:
kan-84-update

hotungkhanh
hotungkhanh reviewed Oct 9, 2024
View reviewed changes
Copy link
Owner

@hotungkhanh hotungkhanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

hotungkhanh
hotungkhanh approved these changes Oct 9, 2024
View reviewed changes
Copy link
Owner

@hotungkhanh hotungkhanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

@dh-giang-vu dh-giang-vu merged commit 2477bd4 into develop Oct 9, 2024
dh-giang-vu added a commit that referenced this pull request Oct 23, 2024
@dh-giang-vu
Merge pull request #39 from hotungkhanh/kan-84/tab-name
6ca445d 
Kan 84/tab name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotungkhanh hotungkhanh hotungkhanh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dh-giang-vu @hotungkhanh