Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitter-compatible API: POST /friendships/destroy #582

Closed
carols10cents opened this issue Aug 18, 2012 · 7 comments
Closed

twitter-compatible API: POST /friendships/destroy #582

carols10cents opened this issue Aug 18, 2012 · 7 comments

Comments

@carols10cents
Copy link
Contributor

This is a smaller story broken out from #562.

This issue is just to make POST /friendships/destroy work like the twitter API. This route doesn't currently exist at all, but there is a nice update json decorator for you to use.

Ignore the issue of client authentication for the moment; just make this work as a normally authenticated user in the browser for now (see #564 about authentication)

https://dev.twitter.com/docs/api/1/post/friendships/destroy

Description: Allows the authenticating users to unfollow the user specified in the ID parameter.

Definitely interpret anything in the twitter docs so that it makes sense for rstat.us, and definitely ask if you have any questions!

Leave a comment if you're working on this.

@Nakort
Copy link

Nakort commented Oct 6, 2012

I will start working on this

@LennonRubin
Copy link

Hey Nakort. I'm working on friendships create so perhaps we should collaborate on this.

@Nakort
Copy link

Nakort commented Oct 10, 2012

Hey Lennon, Do you have a branch you are working on?

@LennonRubin
Copy link

I've pushed my local branch to my personal dev fork here: https://github.com/LennonRubin/rstat.us/tree/twitter-friendships

I'm not sure if that's the proper way to go about collaborating on a side branch. Let me know if you think we should do it differently.

As of now I haven't done much but I did create the controller you'll want to use in controllers/api and also found a useful method called "requested_user!" that I've copied over from the statuses controller. We'll want to somehow factor that out but I didn't want to step on anybody's toes at this point because I think somebody is working on that file.

Other than that I've just changed some routes and not much else. I have however identified that we're going to want to use a decorator, probably called user_twitter_json_decorator.rb (not created) just like whoever did the update api functions has created one called update_twitter_json_decorator.rb

@Nakort
Copy link

Nakort commented Oct 10, 2012

Can someone check and see if this is what is expected?, I am not sure If I am using the right methods to find the user and the author. Nakort@6ca5f82

@Nakort
Copy link

Nakort commented Oct 10, 2012

I am not sure either Lennon, but if you can give me commit access to your branch we can both work on it.

@LennonRubin
Copy link

OK, you now should have commit access on my branch.

@Nakort Nakort closed this as completed Oct 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants