Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version 3.1.1 causes ERROR ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor #91

Open
YodaNinja opened this issue Jun 27, 2019 · 4 comments
Assignees

Comments

@YodaNinja
Copy link

Updating to the latest version, 3.1.1 causes the runtime error:
ERROR ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor
Reverting back to 3.1.0 resolves the issue.

This occurs with angular 7 production build.
Looking at the changes v3.1.0...v3.1.1, it looks like a number of angular version and compiler version changes were done.

I've a feeling this is most likely related to this issue:
angular/angular-cli#14416
with a fix only targeted for angular 8: angular/devkit#981

@asyncLiz
Copy link
Collaborator

Yikes, that's a good find.

I'll do some digging to see if I can figure out if there's a way to fix it for Angular 7. If not, we may have to break out into a new major version for Angular 8 support.

@asyncLiz asyncLiz self-assigned this Jun 27, 2019
@maxim1006
Copy link

Hello, any luck on that?

@maxim1006
Copy link

Updating to the latest version, 3.1.1 causes the runtime error:
ERROR ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor
Reverting back to 3.1.0 resolves the issue.

This occurs with angular 7 production build.
Looking at the changes v3.1.0...v3.1.1, it looks like a number of angular version and compiler version changes were done.

I've a feeling this is most likely related to this issue:
angular/angular-cli#14416
with a fix only targeted for angular 8: angular/devkit#981

Hello, please tell more about fix for a7

@asyncLiz
Copy link
Collaborator

asyncLiz commented Sep 3, 2019

Things have been pretty hectic IRL for me right now, so things like Origami have taken a back seat in priority :(

I'd welcome a PR for this though!

@maxim1006 to fix it for Angular 7, npm install --save-exact @codebakery/origami@3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants