Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All dependencies are outdated #44

Closed
thebitstick opened this issue Oct 12, 2018 · 6 comments
Closed

All dependencies are outdated #44

thebitstick opened this issue Oct 12, 2018 · 6 comments
Milestone

Comments

@thebitstick
Copy link

Please consider updating the dbus crate from 0.4.1 to 0.6.3.

Currently when compiling there is a warning about a "redundant linker flag" for dbus, that has been resolved in newer versions of the dbus crate.
Also security issues and such, but this redundant linker flag is much more important.
Also image crate from 0.19 to 0.20.0.
Also lazy_static crate from 1.0 to 1.1.0.

@thebitstick thebitstick changed the title Dependency 'dbus' is outdated All dependencies are outdated Oct 12, 2018
@hoodie
Copy link
Owner

hoodie commented Oct 13, 2018

thank you - I've been putting this off for some time, updating to 0.6.x of dbus would require significant changes, so I was always weary of updating that. Basically the server module would have to be completely rewritten.

@hoodie
Copy link
Owner

hoodie commented Oct 13, 2018

I guess it's finally time to do this

@thebitstick
Copy link
Author

Why would it need to be rewritten?

@hoodie
Copy link
Owner

hoodie commented Oct 13, 2018

the API of dbus-rs change significantly in 0.6

@hoodie hoodie added this to the v3.5.0 milestone Oct 13, 2018
@hoodie hoodie closed this as completed Oct 21, 2018
@hoodie
Copy link
Owner

hoodie commented Oct 21, 2018

thanks to @thebitstick for reminding me to finally do this. Please let me know if you find any issues with the new version

@thebitstick
Copy link
Author

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants