Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(service-worker): fix module docs for service worker adapter #3645

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

rwv
Copy link
Contributor

@rwv rwv commented Nov 8, 2024

change from Cloudflare Workers to Service Worker

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

change from `Cloudflare Workers` to `Service Worker`
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (65f2a3b) to head (9e6c34c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3645   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files         159      159           
  Lines       10135    10135           
  Branches     2944     2849   -95     
=======================================
  Hits         9292     9292           
  Misses        841      841           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe yusukebe changed the title docs: fix module docs for service worker adapter docs(service-worker): fix module docs for service worker adapter Nov 8, 2024
@yusukebe
Copy link
Member

yusukebe commented Nov 8, 2024

@rwv

Thanks! Merging.

@yusukebe yusukebe merged commit 8a8a576 into honojs:main Nov 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants