chore: podman support for devcontainer #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3529 +/- ##
==========================================
+ Coverage 94.29% 94.30% +0.01%
==========================================
Files 157 157
Lines 9488 9488
Branches 2763 2813 +50
==========================================
+ Hits 8947 8948 +1
+ Misses 541 540 -1 ☔ View full report in Codecov by Sentry. |
|
Looks good! Thank you. |
TinsFox
pushed a commit
to TinsFox/hono
that referenced
this pull request
Oct 28, 2024
* chore: add podman devcontainer support * chore: remove deprecation warning * chore: add extensions to devcontainer --------- Co-authored-by: Marco Muser <marco.muser@enpal.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues when using the Devcontainer setup in VS Code with Podman. This PR changes the devcontainer.json to allow the use of Podman. Docker usage should not be affected. It also adds the Prettier and ESLint Extensions for VS Code explicitly to the Devcontainer.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code