Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish hono jsx support and parsing as separate package #1647

Open
shellscape opened this issue Nov 5, 2023 · 2 comments
Open

feat: publish hono jsx support and parsing as separate package #1647

shellscape opened this issue Nov 5, 2023 · 2 comments
Labels
enhancement New feature or request.

Comments

@shellscape
Copy link

What is the feature you are proposing?

Hey there 👋

I'm developing https://jsx.email and have been following hono's JSX support with great interest. The latest addition of Suspense that's due to drop soon is very interesting for our use case, and we're planning on adopting that into our project. However, it would be amazing if the team would consider publishing that as a separate package so projects like jsx-email could depend on that rather than the entire hono framework.

I know this is a bit of a wonky ask, but curious to see what the reaction to it is.

@shellscape shellscape added the enhancement New feature or request. label Nov 5, 2023
@yusukebe
Copy link
Member

yusukebe commented Nov 5, 2023

Hi @shellscape,

I can share two points regarding this.

  1. Please evaluate the implications post-usage. The Suspense feature hasn't been released yet and will initially be tagged as experimental. You're welcome to use it and then assess whether it meets your expectations or not.
  2. Your primary concern might be regarding package separation. We have a policy against separating packages used in Hono, like the routers. The rationale is that managing different packages can complicate maintenance. It becomes challenging to make breaking changes to such routers or JSX libraries, whereas with a unified package, we are less concerned about altering the APIs of routers and JSX. Additionally, another policy is that the Hono core should not have external libraries, even if they are under the @hono/.+ scope. Although it's worth considering making it a separate package, this will not happen anytime soon.

@thetutlage
Copy link

It will be nice to document the standalone usage of rendering JSX with hono. The use case is writing emails content using JSX and render them outside of HTTP requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants