Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore to all examples and generated from cli #1364

Open
masterbater opened this issue Aug 22, 2023 · 4 comments
Open

Add gitignore to all examples and generated from cli #1364

masterbater opened this issue Aug 22, 2023 · 4 comments
Labels
enhancement New feature or request.

Comments

@masterbater
Copy link

What is the feature you are proposing?

Its better if you provide a default gitignore files, sometimes I forgot I didnt gitignore node_modules and some env files.

@masterbater masterbater added the enhancement New feature or request. label Aug 22, 2023
@yusukebe
Copy link
Member

Hi @masterbater !

Did you say about the "create hono" command?

@masterbater
Copy link
Author

Hi @masterbater !

Did you say about the "create hono" command?

Yes, I use pnpm and it doesnt have any gitignore file in it

@masterbater
Copy link
Author

Hi @masterbater !

Did you say about the "create hono" command?

Bun or nodejs has node_modules, I know its my responsibility to add gitignore, But I just make a quick spinning up a hono server and I notice when I git push it takes a while.
image

@yusukebe
Copy link
Member

@masterbater

I agree with your observation. We should indeed include a .gitignore file. I've already set up the .gitignore for Cloudflare Workers and Pages templates. We'll need to integrate it into other projects, such as Bun, Node.js, and others.

Please feel free to open a PR addressing this in the "Create Hono" repository: https://github.com/honojs/starter. If not, I'll consider doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants