Skip to content

Commit bf73ea9

Browse files
authored
Allow unknown LSP enum values (microsoft#582)
1 parent ecf72b0 commit bf73ea9

File tree

2 files changed

+80
-358
lines changed

2 files changed

+80
-358
lines changed

internal/lsp/lsproto/_generate/generate.mjs

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -399,31 +399,8 @@ for (const t of model.enumerations) {
399399
writeLine("if err := json.Unmarshal(data, &v); err != nil {");
400400
writeLine("return err");
401401
writeLine("}");
402-
writeLine("switch v {");
403-
const values = [...new Set(t.values.map(v => v.value))].sort(compareValues);
404-
for (let i = 0; i < values.length; i++) {
405-
const v = values[i];
406-
if (i === 0) {
407-
write("case ");
408-
}
409-
write(valueToLiteral(v));
410-
if (i === values.length - 1) {
411-
writeLine(":");
412-
}
413-
else {
414-
if (i % 3 === 2) {
415-
writeLine(",");
416-
}
417-
else {
418-
write(", ");
419-
}
420-
}
421-
}
422402
writeLine("*e = " + t.name + "(v)");
423403
writeLine("return nil");
424-
writeLine("default:");
425-
writeLine(`return fmt.Errorf("unknown ${t.name} value: %v", v)`);
426-
writeLine("}");
427404
writeLine("}");
428405
writeLine("");
429406
}

0 commit comments

Comments
 (0)