Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped events show up as errors on the reponse queue #163

Open
vreynolds opened this issue Jan 24, 2022 · 0 comments
Open

Dropped events show up as errors on the reponse queue #163

vreynolds opened this issue Jan 24, 2022 · 0 comments
Labels
type: discussion Requests for comments, discussions about possible enhancements. type: enhancement

Comments

@vreynolds
Copy link
Contributor

Initially discovered in honeycombio/agentless-integrations-for-aws#96

When libhoney drops an event due to sampling, it puts an error on the response queue "event dropped due to sampling". This is confusing on the receiving end, because it's not really an error, nothing went wrong.

It seems this was implemented as an error, because of the limitation of the Response struct -- there's not really a better field to add the message that event was sampled out

  • can we change the libhoney to communicate a sampled out event in a non-error way?
  • alternatively, consumers like the agentless integration can be aware of this special case, and have special handling for sampling "errors"
@vreynolds vreynolds added type: enhancement type: discussion Requests for comments, discussions about possible enhancements. and removed type: bug labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Requests for comments, discussions about possible enhancements. type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant