Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up mixins #4076

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Clean up mixins #4076

merged 2 commits into from
Oct 20, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 20, 2019

This cleans up our mixins. Instead of using the Constructor type in lit-element package, we now use the one that is prescribed by TypeScript (microsoft/TypeScript#13743). This one will work with the mixin pattern, so we don't need to ts-ignore things. Gives us a great neat little clean up.

I removed the no longer used Localize Lite mixin for Polymer, allowing me to fold the Localize Lite base mixin into the Lit one.

@bramkragten bramkragten merged commit 785453a into dev Oct 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the mixin-cleanup branch October 20, 2019 12:32
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees
No one assigned
Labels
cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balloob @bramkragten @iantrich @homeassistant