Handle short form hex colors in conversion functions #24642
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Some themes use short form hex codes like
#F00
, but our color converters don't understand this for things like graph colors and energy dashboard.We can handle this by converting to long form in the theme conversion function.
Also update to strip alpha codes from hex colors, in case some people accidentally use them (similar to how we already ignore for
rgba()
). The only use of this function is currently in graph cards where alpha channel is always manually manipulated, so we don't want it. If some other use comes up in the future, we could modify the function with an optional parameter to keep or toss the alpha.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: