Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve chart height and narrow option in grid section #24046

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Feb 3, 2025

Proposed change

  • Don't set min rows according to the number of entities as it only works for timeline chart.
  • Improve narrow and full height logic by checking is the value is a number.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2025.2 milestone Feb 3, 2025
@piitaya piitaya requested a review from MindFreeze February 3, 2025 14:02
@piitaya piitaya changed the title Improve chart height in grid section Improve chart height and narrow option in grid section Feb 3, 2025
@MindFreeze MindFreeze enabled auto-merge (squash) February 3, 2025 14:12
@MindFreeze MindFreeze merged commit 67b970f into dev Feb 3, 2025
11 checks passed
@MindFreeze MindFreeze deleted the fix_chart_height_grid_section branch February 3, 2025 14:12
bramkragten pushed a commit that referenced this pull request Feb 3, 2025
* Fix chart size in grid

* Set minimal height to 2 for history chart

* Update history chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants