Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosign support #95236

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Cosign support #95236

merged 2 commits into from
Jun 26, 2023

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jun 26, 2023

Breaking change

The internal images are not pushed to docker.io anymore, as we now do with all other internal images.
If someone did not follow our docs and did something's own on his end, it could be that he use an internal image and not the official one. So it's only a breaking change if he does not use the official images according to our docs over docker.io

Proposed change

Use now cosign to sign the images

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Jun 26, 2023
@home-assistant home-assistant bot marked this pull request as draft June 26, 2023 10:57
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@pvizeli pvizeli marked this pull request as ready for review June 26, 2023 11:58
@home-assistant home-assistant bot requested a review from frenck June 26, 2023 11:58
@frenck frenck merged commit c75e831 into dev Jun 26, 2023
@frenck frenck deleted the cosign-support branch June 26, 2023 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants