-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linear Garage Door integration #91436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Oops, didn't mean to include both 😅 |
0f88f46
to
eb7b4f6
Compare
2436862
to
46655be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a first pass!
I'm not a core maintainer - so don't feel like you have to listen to anything I say, but hopefully this is helpful!
46655be
to
d109494
Compare
df4db94
to
c692d31
Compare
c692d31
to
7835ba4
Compare
25727c0
to
68bc4a6
Compare
5303d5b
to
27e8f4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now, just a question about the device_id which is generated by the config flow.
await hub.login( | ||
data["email"], | ||
data["password"], | ||
device_id=device_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the device_id
is just a random string?
Is it OK that the device_id
is reset during reauth?
Also, there's another "device_id" used to build entity unique_id, could you give this one a different name so it's clearer which is which?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, the device_id
generated by the config flow is the ID of the device making the request (Home Assistant). It serves no purpose other than to identify Home Assistant to Linear's servers. The device_id
in the cover
entity is the device ID of the garage door opener itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @IceBotYT 👍
Should I update the branch too? I don't have access to my computer at the moment so should I just use the update branch with rebase button? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure CI is passing
Proposed change
I am adding a new integration which allows users to control Linear garage doors from Home Assistant.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: