-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIFX: assume default features for unknown products #8553
Conversation
@amelchio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @shmuelzon to be potential reviewers. |
I put that lifx.py in my custom_components directory and restarted, but I can't see any particular differences in the logging results. |
Try giving it a different name like |
While custom_components should override the builtin ones this seems to be another problem.. I've renamed to lightest.py and set the platform to lightest and it's not loading. I could have sworn I had done exactly this before in the past. Will need to look at this tomorrow as it's nearing midnight.. |
Ah, probably it should go into Edit: confirmed, but then you need to copy |
@cmsimike I am unable to reproduce this problem. Can you try my fixed version and tell me what it logs? Also, is this a permanent issue or does it only happen sometimes? |
@amelchio Permanent issue. I will look into running this version locally and get back to you asap. |
Not sure what services.yaml is. I can't seem to load the component without it. |
Ok I copied the file from the hass dir into my custom_components and got hass started. My light is picked back up!!! I am getting this warning in the logs, however:
|
@cmsimike Hmmm, product id 14 is not listed in the official LIFX product map. I wonder how you got such a version but that does explain why things didn't work before. Thanks for testing! |
@amelchio I'm sure lifx sent it to me by mistake. Thank YOU for your quick fix on this. |
OK. Just read that this has been solved.. So will follow the same process. |
@mihalski Something's very wrong there. You have six bulbs with IP address 192.168.1.1 which seems more like a router address. Are you running the bulbs through a router/firewall/something that does NAT? |
No. Nothing like that. And as you can see, the router doesn't see them on those IP's either. |
That's crazy. Are you able to do a tcpdump on the HA machine? |
Not without great difficulty.. But I'll see what I can do. I need to set up my spare RPi2 with Raspbian and then figure out how to statically build tcpdump so that I can use it from within the hassio container.
|
Never mind, that's not worth the trouble. I will try installing hassio, maybe it is playing some networking tricks? |
This makes the detection work for prototypes as well.
e5c62b2
to
5683d87
Compare
Trouble is my middle name (or so they tell me).
Is there something specific you would like me to do to help debug this? |
Since the comments are no longer relevant to this PR, and the fix seems to be confirmed, I'm merging this. Please try to keep PRs on topic next time @mihalski |
@mihalski Well, a start would be
to check whether these packets are really sent. This has turned into quite its own topic and no HA code can fix duplicate IP addresses, so I will go ahead and close this issue. Maybe we can continue the debugging discussion in Gitter? |
This makes the detection work for prototypes as well.
This makes the detection work for prototypes as well.
Description:
This makes the detection work for prototypes as well.
Reported in aiolifx/aiolifx#21 by @cmsimike
Checklist:
If the code communicates with devices, web services, or third-party tools:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable (example).New dependencies are only imported inside functions that use them (example).requirements_all.txt
by runningscript/gen_requirements_all.py
.New files were added to.coveragerc
.