Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyroon library to 0.1.2. #84865

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Bump pyroon library to 0.1.2. #84865

merged 1 commit into from
Dec 30, 2022

Conversation

pavoni
Copy link
Contributor

@pavoni pavoni commented Dec 30, 2022

Proposed change

This bumps the pyroon library to 0.1.2. This fixes two bugs for HA users.

The library changes are shown here:-
pavoni/pyroon@0.1.1...0.1.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

There are two significant changes for HA users. The updated websocket_client library fixes some reconnection issues - which is likely to fix the long standing disconnection issue above.

The other change is a revised way of parsing the strings passed via 'play_media' . Roon requires a path to the roon media to be played - the old library code didn't allow quoting - which stopped genres and tracks that contained forward slashes being played. The new code allows simple quoting.

To help with the load of incoming pull requests:

@balloob balloob added this to the 2023.1.0 milestone Dec 30, 2022
@balloob balloob merged commit 3e18d70 into dev Dec 30, 2022
@balloob balloob deleted the bump_pyroon branch December 30, 2022 18:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants