Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Drop aiohttp to 3.8.1 from 3.8.3.
3.8.3 included "fix" aio-libs/aiohttp#6719 to align the behavior of aiohttp with the documentation, which is that request handlers no longer get cancelled when the client disconnects. We did not anticipate such a behavioral change in a patch release and so didn't catch this in time. It seems like it contains a bug where a
StreamResponse
will not raise when written to, causing our MJPEG streams to eat up all the memory (as it writes a new image every 0.5s to the stream without any back pressure).In aio-libs/aiohttp#7056 a new parameter was added that allows enabling the old cancellation behavior. This has not been released yet.
Before upgrading, we should explore if we want cancellation and if we don't, we should fix the
StreamResponse
eating all the memory. Two tests got fixed in #82788 for the 3.8.3 upgrade, which are at least 2 spots that would need to fix.Fixes #83661
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: