-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base image to 2022.11.0 #82527
Conversation
Let's handle that on the base image. I created a new release, so we can use a new base image to fix it 👍 |
This is not a fix, but a workaround. This was acknowledged upstream as well, the last question asked was: If raising it would fix the issue and let him know. The issue was closed, nobody answered. I suggest we answer his questions and get it adjusted upstream (instead of just patching our end). |
@frenck in fact there are two solutions for this issue:
So, our best option is still 2, I guess. |
unable to s6_svstatus_read
error90436eb
to
f0d3fe8
Compare
@frenck, update:
|
@felipecrs You are missing my point in my comment: ☝️ No one ever communicated anything about it back. IMHO it is the main reason it doesn't have a better default out of the box. |
@frenck I see. Well, that's odd indeed. I'll try to find a way to replicate the issue and test by myself. It's difficult because it's very rare. |
Just to be clear, increasing the |
I posted news at just-containers/s6-overlay#460, copying from there: I wrote a simple script to test it for me: #!/bin/bash
function test() {
rm -f "$1"-log.txt
local attempts=500
local failures=0
for i in $(seq 1 $attempts); do
clear
echo "S6_SERVICES_READYTIME=${1} - Attempt $i of $attempts"
set -x
docker rm -f test
docker run --name test --env=S6_SERVICES_READYTIME="$1" --rm -d ghcr.io/home-assistant/generic-x86-64-homeassistant:2022.11.4
sleep 1.25s
set +x
if docker logs test 2>&1 |
tee /dev/stderr |
grep -q "s6-svwait: fatal: unable to s6_svstatus_read: No such file or directory"; then
echo "attempt ${i} at $(date)" >> "$1"-log.txt
failures=$((failures + 1))
# Bell
echo -e '\a'
fi
done
echo "Failed ${failures} out of ${attempts} attempts for S6_SERVICES_READYTIME=${1}" >> result.txt
}
test 0
test 5
test 50 Here's the result:
Failures for
Failures for
I think this is conclusive, I can safely say that increasing |
Breaking change
No.
Proposed change
Fixes intermittent s6-overlay error that prevents Home Assistant from starting.
Type of change
Additional information
unable to s6_svstatus_read
error docker-base#193Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: