-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Wallbox price unit #82420
Fix Wallbox price unit #82420
Conversation
@MartinHjelmare regarding comment #82039 (comment), I fix this in this PR. The api does provide the relevant 3-letter codes (I just made a mistake in te test ;-)). Also, regarding your other question, this is just the price per kWh (doesn't increase, cannot be summarized). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the unit is eg EUR / kWh we shouldn't use the currency device class. Please remove the currency device class and update the sensor unit to the correct one, including /kWh
.
@MartinHjelmare I pushed a change that removes the deviceclass and creates a dynamic UoM -> [currency]/kWh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix wrong currency value in the tests for wallbox
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: