Add OSO Energy integration #70365
Add OSO Energy integration #70365
Conversation
probot-home-assistant
bot
added
has-tests
new-integration
integration: osoenergy
labels
|
@osohotwateriot Im planning to buy OSO Charge and this integration is very interesting. Do you plan to still work on change requests in this PR? Thanks for the effort including it in the core! |
osohotwateriot
force-pushed
the
osoenergy
branch
from
ad6ad62
to
d74babc
Compare
osohotwateriot
force-pushed
the
osoenergy
branch
from
d74babc
to
1d5ba58
Compare
|
Is this PR ready to be merged or are there any review comments left to be fixed? Im eager to get my water heater included in HA with this integration. |
|
All comments have been reviewed and fixed - code is pushed. @ludeeus can you verify if there is something else needed for the PR in order to proceed with the approval? |
|
@ludeeus any chance you will get time to review and merge this PR before the holidays kicks in? |
|
Any reason for not merging? |
Co-authored-by: Robert Resch <robert@resch.dev>
There was a problem hiding this comment.
Looks good, thanks @osohotwateriot 👍
Congrats to the first PR 🎉
Changing the name of the TypeVar can be done in a follow-up PR.
| _T = TypeVar( | ||
| "_T", OSOEnergyBinarySensorData, OSOEnergySensorData, OSOEnergyWaterHeaterData | ||
| ) |
There was a problem hiding this comment.
Let's give this TypeVar a better name, maybe:
| _T = TypeVar( | |
| "_T", OSOEnergyBinarySensorData, OSOEnergySensorData, OSOEnergyWaterHeaterData | |
| ) | |
| _OSOEnergyT = TypeVar( | |
| "_T", OSOEnergyBinarySensorData, OSOEnergySensorData, OSOEnergyWaterHeaterData | |
| ) |
| return unload_ok | ||
|
|
||
|
|
||
| class OSOEnergyEntity(Entity, Generic[_T]): |
There was a problem hiding this comment.
| class OSOEnergyEntity(Entity, Generic[_T]): | |
| class OSOEnergyEntity(Entity, Generic[_OSOEnergyT]): |
|
|
||
| async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: | ||
| """Unload a config entry.""" | ||
| unload_ok = await hass.config_entries.async_unload_platforms(entry, PLATFORMS) |
There was a problem hiding this comment.
This will error if the platform wasn't setup.
| """Handle a OSO Energy config flow.""" | ||
|
|
||
| VERSION = 1 | ||
| CONNECTION_CLASS = config_entries.CONN_CLASS_CLOUD_POLL |
There was a problem hiding this comment.
This is legacy. It's set in the manifest.json nowadays.
| """Re Authenticate a user.""" | ||
| self.entry = self.hass.config_entries.async_get_entry(self.context["entry_id"]) | ||
| data = {CONF_API_KEY: user_input[CONF_API_KEY]} | ||
| return await self.async_step_user(data) |
There was a problem hiding this comment.
We shouldn't pass the old config entry data as input to the user step. Then we'll try to authenticate again with the old data when we know it's already invalid.
| } | ||
| }, | ||
| "error": { | ||
| "cannot_connect": "[%key:common::config_flow::error::cannot_connect%]", |
There was a problem hiding this comment.
cannot_connect string isn't used.
| "error": { | ||
| "cannot_connect": "[%key:common::config_flow::error::cannot_connect%]", | ||
| "invalid_auth": "[%key:common::config_flow::error::invalid_auth%]", | ||
| "unknown": "[%key:common::config_flow::error::unknown%]" |
There was a problem hiding this comment.
unknown string isn't used.
| "title": "OSO Energy Auth", | ||
| "description": "Generate and enter a new 'Subscription Key' for your account at 'https://portal.osoenergy.no/'.", | ||
| "data": { | ||
| "api_key": "[%key:common::config_flow::data::api_key%]" |
There was a problem hiding this comment.
There's no form for the reauth step.
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: