Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Docker build caching opportunities #60661

Merged

Conversation

agners
Copy link
Member

@agners agners commented Nov 30, 2021

Breaking change

Proposed change

Install requirements in separate Dockerfile RUN command so docker build
commands can cache that step if requirements don't change. This is
useful for local development when building containers is needed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Install requirements in separate Dockerfile RUN command so docker build
commands can cache that step if requirements don't change. This is
useful for local development when building containers is needed.
@probot-home-assistant probot-home-assistant bot added new-feature small-pr PRs with less than 30 lines. labels Nov 30, 2021
Dockerfile Outdated Show resolved Hide resolved
@agners
Copy link
Member Author

agners commented Dec 1, 2021

Just to make sure that this does not create larger images, I also compared docker history before and after this change. As expected docker history shows more layers now, but total sizes of the layers did not increase.

@frenck frenck merged commit b04b314 into home-assistant:dev Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants