Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Axis non-privileged users work again #36731

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Make Axis non-privileged users work again #36731

merged 2 commits into from
Jun 13, 2020

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jun 12, 2020 •
edited
Loading

Breaking change

Proposed change

Some of the new APIs doesn't work with viewer level privileges, this fixes that. Dependency change is to catch Unauthorized exceptions on new API calls

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Kane610 Kane610 added this to the 0.111.2 milestone Jun 12, 2020
@Kane610 Kane610 self-assigned this Jun 12, 2020
@Kane610 Kane610 changed the title Axis - Fix so integration still works with low privilege users Axis - make non-privileged users work again Jun 12, 2020
@Kane610 Kane610 marked this pull request as ready for review June 12, 2020 20:49
@MartinHjelmare MartinHjelmare changed the title Axis - make non-privileged users work again Make Axis non-privileged users work again Jun 12, 2020
@MartinHjelmare
Copy link
Member

Maybe add a test?

@Kane610
Copy link
Member Author

Kane610 commented Jun 13, 2020

I don't know if I have time today or tomorrow. I hope to do it before the next point release. Else I will add it in a second PR

@bramkragten bramkragten merged commit 78af0a4 into home-assistant:dev Jun 13, 2020
bramkragten pushed a commit that referenced this pull request Jun 13, 2020
@Kane610 @bramkragten
Make Axis non-privileged users work again (#36731)
16d045a
@bramkragten bramkragten mentioned this pull request Jun 13, 2020
Merged
@Kane610 Kane610 deleted the axis-handle_user_priveleges branch June 15, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Kane610 Kane610

Labels
bugfix by-code-owner cherry-picked cla-signed integration: axis small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.2
Development

Successfully merging this pull request may close these issues.

Unable to add Axis Camera with "Viewer" user
4 participants
@Kane610 @MartinHjelmare @bramkragten @homeassistant