Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-synology to 0.8.2 #36410

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Jun 3, 2020

Proposed change

Bump python-synology to 0.8.2

Release notes : https://github.com/ProtoThis/python-synology/releases/tag/0.8.2

Used to add details on the security binary sensor:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@Quentame Quentame added this to the 0.111.0 milestone Jun 3, 2020
@frenck
Copy link
Member

frenck commented Jun 3, 2020

@Quentame You've tagged this for 0.111.0, but that one is already in beta. This does add a new feature, right?

@Quentame
Copy link
Member Author

Quentame commented Jun 3, 2020

@Quentame You've tagged this for 0.111.0, but that one is already in beta. This does add a new feature, right?

Only attributes to a binary sensor merged yesterday, so in 0.111.0.

I thought it would be sad not having them together, but if you think it should not, remove 0.111.0 milestone no worries 😉

@Quentame Quentame merged commit e08ba67 into home-assistant:dev Jun 3, 2020
@Quentame Quentame deleted the synology_dsm/bump branch June 3, 2020 22:18
@MartinHjelmare MartinHjelmare removed this from the 0.111.0 milestone Jun 4, 2020
@MartinHjelmare
Copy link
Member

Removed the milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants