Migrate Tile to use entry.runtime_data #134107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
integration: tile
small-pr
|
Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bachya
reviewed
Dec 27, 2024
| @@ -26,6 +32,7 @@ def __init__(self, hass: HomeAssistant, client: API, tile: Tile) -> None: | |||
| ) | |||
| self.tile = tile | |||
| self.client = client | |||
| self.username = self.config_entry.data[CONF_USERNAME] | |||
There was a problem hiding this comment.
Because I don't really feel like doing coordinator.config_entry.data[CONF_USERNAME] in the unique id attribute and this makes it a bit shorter
| hass.data[DOMAIN].pop(entry.entry_id) | ||
|
|
||
| return unload_ok | ||
| return await hass.config_entries.async_unload_platforms(entry, PLATFORMS) |
There was a problem hiding this comment.
Does entry_data allow this to be removed?
There was a problem hiding this comment.
That happens automatically :D
# Conflicts: # homeassistant/components/tile/device_tracker.py # tests/components/tile/test_config_flow.py
zweckj
requested changes
Dec 27, 2024
|
|
||
| class TileCoordinator(DataUpdateCoordinator[None]): | ||
| """Define an object to coordinate Tile data retrieval.""" | ||
|
|
||
| config_entry: TileConfigEntry | ||
|
|
||
| def __init__(self, hass: HomeAssistant, client: API, tile: Tile) -> None: |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
19 tasks
zweckj
approved these changes
Dec 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrate Tile to use entry.runtime_data
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: