Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup devices in Nord Pool from reconfiguration #134043

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Cleanup devices in Nord Pool from reconfiguration #134043

merged 3 commits into from
Dec 27, 2024

Conversation

gjohansson-ST
Copy link
Member

Proposed change

Clean up devices (services) and entities from a reconfiguration of the config entry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Comment on lines 75 to 77
entities = er.async_entries_for_device(entity_reg, entry.id)
for _entity in entities:
entity_reg.async_remove(_entity.entity_id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
entities = er.async_entries_for_device(entity_reg, entry.id)
for _entity in entities:
entity_reg.async_remove(_entity.entity_id)

entities will be cleaned up automatically once the config entry is removed from the device. The below code is preferred because other integrations might be connected to the same device

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The below code is preferred because other integrations might be connected to the same device.

The other method uses async_update_device but I guess there is some reason why it exists, but I'll take a look at that some other time.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 27, 2024 20:11
@gjohansson-ST gjohansson-ST marked this pull request as ready for review December 27, 2024 20:25
@home-assistant home-assistant bot requested a review from zweckj December 27, 2024 20:25
@zweckj zweckj merged commit d676169 into dev Dec 27, 2024
34 checks passed
@zweckj zweckj deleted the gj-20241226-02 branch December 27, 2024 20:33
@gjohansson-ST gjohansson-ST added this to the 2025.1.0 milestone Dec 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants