Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overseerr integration #133981

Merged
merged 10 commits into from
Dec 28, 2024
Merged

Add Overseerr integration #133981

merged 10 commits into from
Dec 28, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Dec 24, 2024

Proposed change

Add Overseerr integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek marked this pull request as ready for review December 26, 2024 10:32
homeassistant/components/overseerr/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/overseerr/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/overseerr/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/overseerr/quality_scale.yaml Outdated Show resolved Hide resolved
try:
return await self.client.get_request_count()
except OverseerrConnectionError as err:
raise UpdateFailed(f"Error communicating with API: {err}") from err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's translate this and set the item in the quality scale to done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missed this one

homeassistant/components/overseerr/sensor.py Show resolved Hide resolved
homeassistant/components/overseerr/sensor.py Outdated Show resolved Hide resolved
tests/components/overseerr/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/overseerr/test_sensor.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 26, 2024 13:06
@joostlek joostlek marked this pull request as ready for review December 27, 2024 10:45
@home-assistant home-assistant bot requested a review from zweckj December 27, 2024 10:45
@joostlek joostlek merged commit 268c21a into home-assistant:dev Dec 28, 2024
65 checks passed
@joostlek joostlek deleted the overseerr branch December 28, 2024 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants