Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cleanup_closed on python 3.12.7+ and 3.13.1+ #129645

Merged
merged 4 commits into from
Nov 3, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 1, 2024

Proposed change

python/cpython#118960 has been fixed which means
cleanup closed should no longer be needed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

python/cpython#118960 has been fixed which means
cleanup closed should no longer be needed
@bdraco bdraco requested a review from a team as a code owner November 1, 2024 17:49
@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Nov 1, 2024
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Nov 3, 2024

thanks

@bdraco
Copy link
Member Author

bdraco commented Nov 3, 2024

test failure is unrelated

FAILED tests/components/advantage_air/test_sensor.py::test_sensor_platform_disabled_entity - AssertionError: assert 3 == 2

@bdraco bdraco merged commit dfbb763 into dev Nov 3, 2024
41 of 42 checks passed
@bdraco bdraco deleted the cleanup_closed_fix branch November 3, 2024 03:15
@epenet
Copy link
Contributor

epenet commented Nov 3, 2024

test failure is unrelated

FAILED tests/components/advantage_air/test_sensor.py::test_sensor_platform_disabled_entity - AssertionError: assert 3 == 2

I am not sure exactly why - but it is definitely related.
All full CI jobs are failing since then, and are resolved if this is reverted.

@epenet epenet mentioned this pull request Nov 3, 2024
19 tasks
bdraco added a commit that referenced this pull request Nov 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants