-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cleanup_closed on python 3.12.7+ and 3.13.1+ #129645
Conversation
python/cpython#118960 has been fixed which means cleanup closed should no longer be needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thanks @bdraco 👍
thanks |
test failure is unrelated FAILED tests/components/advantage_air/test_sensor.py::test_sensor_platform_disabled_entity - AssertionError: assert 3 == 2 |
I am not sure exactly why - but it is definitely related. |
Proposed change
python/cpython#118960 has been fixed which means
cleanup closed should no longer be needed
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: