Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codefences from issue titles #127254

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

rytilahti
Copy link
Member

Proposed change

The issue titles do not support codefencing with backticks, but will instead display them as-is (unwanted behavior shown in the 2nd screenshot at #126349 (comment)).
This PR removes the backticks from all issue titles, but leaves fix_flow titles untouched (see notify/strings.py lines lines 71 and 82) as I'm not sure if they are handled similarly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@rytilahti rytilahti requested review from a team and bdraco as code owners October 1, 2024 22:17
@frenck frenck added this to the 2024.10.0 milestone Oct 2, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @rytilahti 👍

../Frenck

@frenck frenck merged commit cd090ff into dev Oct 2, 2024
45 checks passed
@frenck frenck deleted the janitor/remove_codefences_from_issue_titles branch October 2, 2024 06:27
frenck pushed a commit that referenced this pull request Oct 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants