Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows unload when unsupported devices vesync #127153

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

cdnninja
Copy link
Contributor

@cdnninja cdnninja commented Oct 1, 2024

Proposed change

Solves an issue where reloading the integration fails. This seems to happen when you have unsupported devices that never loaded in the first place.

Similar error mentioned here: #117268

An example of what I get as an example before this change is implemented:

Logger: homeassistant.config_entries
Source: config_entries.py:809
First occurred: 10:14:17 PM (1 occurrences)
Last logged: 10:14:17 PM

Error unloading entry jaydenaphillips@gmail.com for vesync
Traceback (most recent call last):
  File "/workspaces/core/homeassistant/config_entries.py", line 809, in async_unload
    result = await component.async_unload_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspaces/core/homeassistant/components/vesync/__init__.py", line 140, in async_unload_entry
    hass.data[DOMAIN].pop(entry.entry_id)
KeyError: '01J5EYRD1YWJN92SD4C2Z4V0SK'

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 1, 2024

Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek added this to the 2024.10.0 milestone Oct 1, 2024
@joostlek joostlek merged commit f02f0ea into home-assistant:dev Oct 1, 2024
31 checks passed
frenck pushed a commit that referenced this pull request Oct 1, 2024
Allows unload when unsupported devices
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@cdnninja cdnninja deleted the fails_unload branch October 19, 2024 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants