-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go2rtc and extend camera integration for better WebRTC support #124410
Conversation
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
My impression is that https://www.home-assistant.io/integrations/rtsp_to_webrtc/ already supports go2rtc because go2rtc exports the same API as RTSPToWebRTC for backwards compatibility/forking. However, i don't think the documentation is updated. Can we either or both (1) Improve usability for of rtsp_to_webrtc by improving documentation or making a virtual integration etc so that the same integration is used but with a different brand/name/icon (2) add any functionality missing to the rtsp to webrtc client library needed for go2rtc? though i'm not actually sure what functionality is missing |
A couple other considerations: |
The go binary will be installed and shipped with the docker image. The code was only copied from the current custom component and is handy to test everything I just opened the PR to make testing the code on multiple machines easier. The PR is far from completed |
OK my point was that my impression was rtsp_to_webrtc already works with go2rtc, RTSPtoWebRTC, and RTSPtoWeb so i'm questioning if we need both. For example the current client is adaptive supporting two different protocols and decides which one to do so if you want more functionality it could support a 3rd type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to registrer a list of ice servers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look at the tests yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are missing for go2rtc init module.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Test coverage is now 100%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Breaking change
Proposed change
Library: https://github.com/home-assistant-libs/python-go2rtc-client
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: