Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to emoncms #122547

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Add tests to emoncms #122547

merged 7 commits into from
Jul 24, 2024

Conversation

alexandrecuer
Copy link
Contributor

@alexandrecuer alexandrecuer commented Jul 24, 2024

Proposed change

Add tests to emoncms before migrating to config flow

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @borpin, mind taking a look at this pull request as it has been labeled with an integration (emoncms) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of emoncms can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign emoncms Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run hassfest

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 24, 2024 16:11
@alexandrecuer
Copy link
Contributor Author

Please run hassfest

thanks, it is done

@alexandrecuer alexandrecuer marked this pull request as ready for review July 24, 2024 17:11
@home-assistant home-assistant bot requested a review from joostlek July 24, 2024 17:11
tests/components/emoncms/conftest.py Outdated Show resolved Hide resolved
tests/components/emoncms/conftest.py Outdated Show resolved Hide resolved
tests/components/emoncms/test_sensor.py Outdated Show resolved Hide resolved
tests/components/emoncms/test_sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 24, 2024 17:35
@alexandrecuer alexandrecuer marked this pull request as ready for review July 24, 2024 19:32
@home-assistant home-assistant bot requested a review from joostlek July 24, 2024 19:32
@joostlek joostlek merged commit fcccd85 into home-assistant:dev Jul 24, 2024
40 checks passed
andrew-codechimp pushed a commit to andrew-codechimp/ha-core that referenced this pull request Jul 25, 2024
* Add tests to emoncms

* Reduce snapshot size

* Reduce snapshot size

* run hassfest to update CODEOWNERS file

* Update requirements_test_all.txt

* Update tests/components/emoncms/test_sensor.py

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

* Dont use snapshot when testing state change

---------

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@alexandrecuer alexandrecuer deleted the add_tests branch October 28, 2024 07:16
@alexandrecuer alexandrecuer restored the add_tests branch October 28, 2024 07:17
@alexandrecuer alexandrecuer deleted the add_tests branch October 28, 2024 07:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants