Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anthropic Claude conversation integration #122526

Merged
merged 11 commits into from
Aug 1, 2024
Merged

Conversation

Shulyaka
Copy link
Contributor

@Shulyaka Shulyaka commented Jul 24, 2024

Proposed change

Add Anthropic Claude conversation agent.

I've decided to not expose top_k and top_p parameters since they usually do more harm than good, but I can add them if required. The temperature is there.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

I'll hold off from reviews because I am unfamiliar with conversation and LLM tools

@tronikos
Copy link
Member

It doesn't seem they allow individual use:

https://support.anthropic.com/en/articles/8987200-can-i-use-the-claude-api-for-individual-use

No. Access to the API is subject to our Commercial Terms of Service and is not intended for individual use.

@Shulyaka Shulyaka closed this Jul 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@balloob balloob reopened this Aug 1, 2024
@home-assistant home-assistant unlocked this conversation Aug 1, 2024
@balloob
Copy link
Member

balloob commented Aug 1, 2024

Discussed with @Shulyaka and moving forward with this PR.

@balloob balloob merged commit 262d778 into home-assistant:dev Aug 1, 2024
40 checks passed
@Shulyaka
Copy link
Contributor Author

Shulyaka commented Aug 1, 2024

Could you also reopen home-assistant/home-assistant.io#33952 and home-assistant/brands#5697 ?

@Shulyaka Shulyaka deleted the claude branch August 2, 2024 00:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants