Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiolifx to 1.0.4 #121267

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Bump aiolifx to 1.0.4 #121267

merged 1 commit into from
Jul 5, 2024

Conversation

Djelibeybi
Copy link
Contributor

Proposed change

Bump aiolifx to 1.0.4 which provides the necessary support for the new LIFX String, Path, Spot, Neon and Ceiling devices.

Aside: I've taken over as maintainer for aiolifx and would like to resume being codeowner for the LIFX integration as well. I'm working on a larger update for the integration to provide Ceiling support in particular. I'll try and get the tests back to 100% as part of that effort, not this PR.

Full changelog: aiolifx/aiolifx@1.0.2...1.0.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Avi Miller <me@dje.li>
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Djelibeybi

@bdraco
Copy link
Member

bdraco commented Jul 5, 2024

Since you are maintaining aiolifx now, please consider switching to a dispatch in unpack.py instead of the if chain:

https://martinheinz.dev/blog/90

@bdraco bdraco merged commit 6c42596 into home-assistant:dev Jul 5, 2024
39 checks passed
@Djelibeybi
Copy link
Contributor Author

Oh, I plan to overhaul unpack.py rather extensively, along with msgtypes.py

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
@Djelibeybi Djelibeybi deleted the bump-aiolifx branch July 12, 2024 01:55
@frenck frenck added this to the 2024.7.3 milestone Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants