Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reolink manual record switch #119232

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Jun 9, 2024

Breaking change

Proposed change

Add a "manual record" switch to the Reolink integration.
Battery camera's can not record continuesly, they will wake upon PIR detection and then decide what kind of event is beeing observed and based on the event and settings will start recording.
This "manual record" switch will wake the camera when turned on and start recording (even if there is no event detected) and keep the camera awake, when turned off, the camera will stop the recording and fall back asleep.

(Note that the "record" switch needs to be ON for this to work since that switch determines if recordings are at all allowed for that camera. So the "record" switch also applies to the PIR/AI detection event based recording).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@jpbede jpbede merged commit b70a33a into home-assistant:dev Jun 9, 2024
24 checks passed
@starkillerOG starkillerOG deleted the reolink_manual_rec branch June 9, 2024 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants