Fix sia custom bypass arming in night mode

[etnoy]

Breaking change

Proposed change

This is an update to #95736 where we remove the custom bypass arming when arming in night mode for the SIA alarm system (Ajax). The reason for this change is because otherwise HA can't distinguish between normal arming and night arming if custom bypass is used.

For example, I have an internal door to the garage which has a door sensor. Sometimes I forget to close it, and the Ajax alarm system warns about it. If I don't feel like getting up and close it before going to bed, Ajax will still arm but with a custom bypass.

The problem is that HA only has "Armed", "Night", and "Custom bypass" alarm states, i.e. there is no way to tell when we are "Custom bypass" armed in "Night" vs in regular "Armed".

I have automations that run only when the system is armed to simulate occupancy. If I forget to close that non-critical internal door I still want that automation to run. Therefore, the automation turns on and off lights randomly in the "Armed" and "Custom bypass" states.

Finally, this means that if I forget to close the door and arm for the night, lights will turn on and off randomly which is annoying.

This change re-maps the custom bypass arming in night mode to say "armed night" instead of "custom bypass".

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @eavanvalkenburg, mind taking a look at this pull request as it has been labeled with an integration (sia) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sia can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign sia Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[frenck]

Thanks, @etnoy 👍

../Frenck