Add Caddx/GE/Interlogix NetworX alarm panel support #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an automated response to help you succeed in getting this PR merged.
If your code communicates with devices:
If your code does not depend on external devices:
|
kk7ds
force-pushed
the
add-nx584-alarm
branch
from
453b393 to
9b61991
Compare
| def setup_platform(hass, config, add_devices, discovery_info=None): | ||
| """ Setup nx584. """ | ||
| host = config.get('host', 'localhost:5007') | ||
|
|
There was a problem hiding this comment.
Can you verify the login is correct?
There was a problem hiding this comment.
There's no login, just connectivity. But I can test connectivity in init and log something, yeah.
kk7ds
force-pushed
the
add-nx584-alarm
branch
from
9b61991 to
a23d4a0
Compare
This changes the service handler dispatch code to always call update_ha_state(), and cleans up the alarm platforms that were calling it themselves.
kk7ds
force-pushed
the
add-nx584-alarm
branch
2 times, most recently
from
8e6c9cc to
b0bdf1e
Compare
| self._alarm = client.Client('http://%s' % host) | ||
| self._alarm.list_zones() | ||
| except requests.exceptions.ConnectionError as ex: | ||
| _LOGGER.error('Unable to connect to NX584: %s', |
There was a problem hiding this comment.
The alarm control panel component will keep polling this device because it has been added on line 38. You could consider catching the exception in setup_platform so that it will not get added to HA.
This adds support for NetworX-based alarm panels and should work for any such panel equipped with a NX584 serial interface module. This includes NX-4/6/8/8E, where the NX8E has this interface built-in. It requires the pynx584 module, and requires running the server component somewhere that has connectivity to the panel via serial, which may include a serial-over-lan connection.
kk7ds
force-pushed
the
add-nx584-alarm
branch
from
b0bdf1e to
3575ddb
Compare
balloob
added a commit
that referenced
this pull request
Feb 7, 2016
Add Caddx/GE/Interlogix NetworX alarm panel support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for NetworX-based alarm panels and should work for
any such panel equipped with a NX584 serial interface module. This
includes NX-4/6/8/8E, where the NX8E has this interface built-in.
It requires the pynx584 module, and requires running the server
component somewhere that has connectivity to the panel via serial,
which may include a serial-over-lan connection.