Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenCV integration #113455

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Remove OpenCV integration #113455

merged 2 commits into from
Mar 15, 2024

Conversation

thecode
Copy link
Member

@thecode thecode commented Mar 14, 2024

Proposed change

Remove OpenCV integration, integration has 0 active users and is broken for over a year, wheels fail to build already on Python 3.11 and doesn't build at all on Python 3.12

History:
Previous attempts: #100468 (comment)
Failed build for Python 3.12: https://github.com/home-assistant/core/actions/runs/8272544052

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Mar 14, 2024

The numpy versions are pinned in pyproject
https://github.com/opencv/opencv-python/blob/68/pyproject.toml#L5

So it will never be able to resolve to a working version of numpy

@bdraco
Copy link
Member

bdraco commented Mar 14, 2024

Supported Python versions
Python 3.x compatible pre-built wheels are provided for the officially supported Python versions (not in EOL):

3.6
3.7
3.8
3.9
3.10

@bdraco
Copy link
Member

bdraco commented Mar 14, 2024

I don't see a solution for this one

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thecode 👍

../Frenck

@frenck frenck merged commit e0b1531 into home-assistant:dev Mar 15, 2024
35 checks passed
@OkhammahkO
Copy link

Just a comment that it has 0 active users because it is broken.

I'm sad to see this go..... I used it for my favourite HA project and was waiting patiently hoping for a fix.

https://community.home-assistant.io/t/timelapse-video-with-computer-vision-make-timelapse-with-bounding-boxes-of-detected-objects-using-your-own-trained-opencv-model/231860?u=mahko_mahko

Oh well. Thanks for your efforts to support it while it was alive.

@thecode thecode deleted the remove-opencv branch March 15, 2024 19:02
@frenck
Copy link
Member

frenck commented Mar 15, 2024

Just a comment that it has 0 active users because it is broken.

It has been broken for a long time, no-one has taken the effort to fix it. At that point, there is not much more we can do.

../Frenck

@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to restart since 2023.6.1 - Unable to install opencv-python-headless
4 participants