Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-bot does not always react to homeassistant bot / probot-home-assistant actions #66260

Closed
wlcrs opened this issue Feb 10, 2022 · 5 comments

Comments

@wlcrs
Copy link
Contributor

wlcrs commented Feb 10, 2022

As I understand the workflow for updating the GitHub Project Boards of core is as follows:

  • homeassistant bot and probot-home-assistant process incoming PR's, and assigns them labels as 'cla-signed', 'integration:', and so on...
  • project-bot reacts to these labels and assigns them to the correct column by looking to the "Automation rules" card of each of these columns.

However, the second step seems to not always happen.

Example 1: PR for existing integration

#64365

image

homeassistant added the label 'cla-signed', which should trigger the following rule for the "Dev"-board:
image

Example 2: New integration

#65000

image

This should have triggered:
image


However, in neither case the project-bot did anything in those PR's. Neither have received any interaction from the core-team (understandable in the case of the new integration, but a bit strange for the PR on the existing integration).

PS. Feel free to direct me to another location to raise this issue, but it seemed like the best spot to do so. It did not receive any suggestion on Discord where it should go.

@wlcrs wlcrs changed the title project-bot does not always react to homassistant bot / probot-home-assistant actions project-bot does not always react to homeassistant bot / probot-home-assistant actions Feb 10, 2022
@ludeeus ludeeus transferred this issue from home-assistant/probot-home-assistant Feb 10, 2022
@wlcrs
Copy link
Contributor Author

wlcrs commented Feb 11, 2022

Thank you @ludeeus for moving this issue to the correct repo.

In the meantime: would it be possible to manually add both PR's to the Project boards? I don't mind waiting my turn to get reviewed by a core team member, but now I have the feeling that I'm waiting fruitlessly for weeks now just because my PR's are not visible to them.

@ludeeus
Copy link
Member

ludeeus commented Feb 11, 2022

I have never used that board, maybe @MartinHjelmare knows

@frenck
Copy link
Member

frenck commented Feb 11, 2022

Project boards aren't drivers or a working concern for reviews. This does not really help.
Nor does the tagging have anything to do with getting PRs reviews.

Thanks for reporting your concern though @wlcrs, but non of the labels or project board changes change the review process at this point.

@MartinHjelmare
Copy link
Member

Yeah, unfortunately we have too many incoming tasks and too few people hours to distribute it on to be able to leverage the project board as it was set up. It worked when we were at around 100 open PRs and had a lower pace.

I check it sometimes and you can find PRs that have been approved but not merged or old PRs not reviewed. But we have too little time to leverage a system where we completely avoid those problems by using a tool like this.

@wlcrs
Copy link
Contributor Author

wlcrs commented Feb 11, 2022

Thank you all for clarifying this. I couldn't find any documentation on how/if these project boards were used.

When I was investigating the project boards, it seemed like a nice enough tool for managing projects like this. But a project of this size gets hard to manage, no matter what tooling you throw at it 🤔

I understand that my PR's are quite large, so I'll patiently wait until you guys get around to it.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants