-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project-bot does not always react to homeassistant bot / probot-home-assistant actions #66260
Comments
Thank you @ludeeus for moving this issue to the correct repo. In the meantime: would it be possible to manually add both PR's to the Project boards? I don't mind waiting my turn to get reviewed by a core team member, but now I have the feeling that I'm waiting fruitlessly for weeks now just because my PR's are not visible to them. |
I have never used that board, maybe @MartinHjelmare knows |
Project boards aren't drivers or a working concern for reviews. This does not really help. Thanks for reporting your concern though @wlcrs, but non of the labels or project board changes change the review process at this point. |
Yeah, unfortunately we have too many incoming tasks and too few people hours to distribute it on to be able to leverage the project board as it was set up. It worked when we were at around 100 open PRs and had a lower pace. I check it sometimes and you can find PRs that have been approved but not merged or old PRs not reviewed. But we have too little time to leverage a system where we completely avoid those problems by using a tool like this. |
Thank you all for clarifying this. I couldn't find any documentation on how/if these project boards were used. When I was investigating the project boards, it seemed like a nice enough tool for managing projects like this. But a project of this size gets hard to manage, no matter what tooling you throw at it 🤔 I understand that my PR's are quite large, so I'll patiently wait until you guys get around to it. |
As I understand the workflow for updating the GitHub Project Boards of
core
is as follows:However, the second step seems to not always happen.
Example 1: PR for existing integration
#64365
homeassistant
added the label 'cla-signed', which should trigger the following rule for the "Dev"-board:Example 2: New integration
#65000
This should have triggered:
However, in neither case the project-bot did anything in those PR's. Neither have received any interaction from the core-team (understandable in the case of the new integration, but a bit strange for the PR on the existing integration).
PS. Feel free to direct me to another location to raise this issue, but it seemed like the best spot to do so. It did not receive any suggestion on Discord where it should go.
The text was updated successfully, but these errors were encountered: