Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung purposefully broke SmartThings integration on Dec 30 #133623

Open
NewsGuyTor opened this issue Dec 19, 2024 · 19 comments
Open

Samsung purposefully broke SmartThings integration on Dec 30 #133623

NewsGuyTor opened this issue Dec 19, 2024 · 19 comments

Comments

@NewsGuyTor
Copy link

The problem

https://community.smartthings.com/t/changes-to-personal-access-tokens-pat/292019

TLDR: Newly generated PATs will only work for 24 hours, which will be absurdly annoying for new users of this integration, so a change to OAuth auth is needed ASAP.

What version of Home Assistant Core has the issue?

NA

What was the last working version of Home Assistant Core?

NA

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@NewsGuyTor NewsGuyTor changed the title Samsung will limit PATs to 24h on Dec 30 2024, breaking SmartThings Samsung will limit PATs to 24h on Dec 30 2024, breaking SmartThings integration Dec 19, 2024
@home-assistant
Copy link

@dengi76
Copy link

dengi76 commented Dec 29, 2024

Hello. I confirm the above! Today my token stopped working, I created a new one and when registering access (on the Samsung website) a notification appeared that access was created for an hour! What should I do?
Thank you!

@CarnsJalone
Copy link

This aligns with what I am seeing. Currently popping open the smartthings component to take a peek at the implementation. Does anyone know of another component that uses oauth 2.0 I can draw architectural reference from?

@joostlek
Copy link
Member

joostlek commented Jan 3, 2025

I'm trying to look into this but it doesn't look like we can use our normal oauth flow.

@ice3m
Copy link

ice3m commented Jan 4, 2025

Whew who ever gets SmartThings to stop giving me rate limits and doesn't make me get a new PAT every 24 hours will be my hero.

Sure you guys have seen it but here's their documentation on the OAuth flow:

https://developer.smartthings.com/docs/connected-services/oauth-integrations

@ozcet
Copy link

ozcet commented Jan 5, 2025

I am an old user of PAT. I restored from backup with mandatory new PAT. Now all my ST integration expired after 24 hours. Any progress for OAuth developement?

@dejatesting2
Copy link

Any word on the OAuth ? Half of my automations break every day due to an invalid token issue

@NewsGuyTor
Copy link
Author

Any word on the OAuth ? Half of my automations break every day due to an invalid token issue

I recommend you make a new thread here: https://community.smartthings.com/latest

@dejatesting2
Copy link

Any word on the OAuth ? Half of my automations break every day due to an invalid token issue

I recommend you make a new thread here: https://community.smartthings.com/latest

Why would I make a thread there? This is an issue with Home Assistant using PATs vs the OAuth method SmartThings wants people to use.... SmartThings has made the change and are not going back, this has to be changed on the home assistant integration side

@gemx
Copy link

gemx commented Jan 8, 2025

Also encountered this problem. Besides the short TTL i can only issue 1 commnd in 20 seconds due to rate limiting.
The integration is just not usable in this state.
Should we file a new ticket as feature request for the OAuth method?

@ozcet
Copy link

ozcet commented Jan 8, 2025

After PAT expire, HA get data only from read-only entities. I cannot execute actions. This is valid only If you do not restart HA. Temperature sensors values are correct. Strange !

@CarnsJalone
Copy link

So after a small bit of investigation, I believe (I am totally new to Home Assistant) that the underlying mechanism of control is the pysmartthings package and the specific method responsible for generating the token is located here.

If you look closely, the type of grant being used is basic (username + password --> very common in personal access token authentication). This is where my gut tells me the change would need to occur.

If my assumptions are correct, there's an additional problem, this repository has been archived on May 9, 2024. I don't know if there's an additional fork of this repository that is being supported.

@LiveMike78
Copy link

I wasn't aware of this and it coincided with me finally tidying up my SmartThings devices with the hass-smarthings-remove script. I thought I'd borked the integration by doing that. Subscribed to this thread to see when a solution drops. It's a major impact for me as my front door lock is connected via SmartThings to add redundancy (if I can't unlock with Home Assistant, I can fall back on SmartThings) but my family all use HA exclusively.

@daath
Copy link

daath commented Jan 11, 2025

Interested in seeing what the solution to this will be ...

@Jens-Wymeersch
Copy link

@joostlek 4% of the community are using this integration (and it is a key feature of NabuCasa). Is there any timeline to fix this problem ?

@NewsGuyTor NewsGuyTor changed the title Samsung will limit PATs to 24h on Dec 30 2024, breaking SmartThings integration Samsung purposefully broke SmartThings integration on Dec 30 Jan 11, 2025
@joostlek
Copy link
Member

Why would it be a key feature of nabu casa?

We're still looking into but trust me, it's difficult. I don't have any timeline as for now

@Jens-Wymeersch
Copy link

@joostlek one of the reasons why I'm using NabuCasa is because the integration with Amazon and Smartthings was made easy. And thank you for taking a crack at it !
Of course, I also wanted to support the home assistant project.

@NewsGuyTor
Copy link
Author

@Jens-Wymeersch I recommend moving away from Samsung products and SmartThings, they broke this on purpose despite having received plenty of warning.

@Jens-Wymeersch
Copy link

@NewsGuyTor we have in total 7 A/Cs - 6 of the 7 are controlled locally but one with smartthings. I'm not planning to replace these devices in the near future (cost is way too high).
I have one a/c left which needs to be replaced, might be thinking of another manufacturer for that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests