Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only attempt loading ESM bundles from URL when running server #7412

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

philippjfr
Copy link
Member

The recent PR that added support for loading ESM bundles from a server endpoint did not consider that in the notebook this wouldn't be possible. This PR ensures that we only attempt to do so when actually running on the server.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (f621f0c) to head (3df8756).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
panel/custom.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7412      +/-   ##
==========================================
+ Coverage   82.22%   82.23%   +0.01%     
==========================================
  Files         337      337              
  Lines       50572    50582      +10     
==========================================
+ Hits        41583    41597      +14     
+ Misses       8989     8985       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 70800fb into main Oct 17, 2024
17 checks passed
@philippjfr philippjfr deleted the server_esm branch October 17, 2024 12:38
ahuang11 pushed a commit that referenced this pull request Oct 18, 2024
* Only attempt loading ESM bundles from URL when running server

* Handle pyodide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant