Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading ESM bundles from URL #7410

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Allow loading ESM bundles from URL #7410

merged 8 commits into from
Oct 17, 2024

Conversation

philippjfr
Copy link
Member

This allows compiled bundles to be loaded from the component resource endpoint which makes it possible for the bundle to be cached by the browser (rather than having to send it across the websocket each time).

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (0b59d53) to head (3b0b2d3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/custom.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7410      +/-   ##
==========================================
- Coverage   82.23%   82.23%   -0.01%     
==========================================
  Files         337      337              
  Lines       50557    50572      +15     
==========================================
+ Hits        41575    41586      +11     
- Misses       8982     8986       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit f621f0c into main Oct 17, 2024
1 check was pending
@philippjfr philippjfr deleted the esm_bundle_fixes branch October 17, 2024 11:00
ahuang11 pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant