Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only postpone setup script if --num-procs is greater than 1 #7289

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 17, 2024

See #6913 (comment)

There is no need to postpone the setup script if we do not run with multiprocessing.

@hoxbro hoxbro added this to the v1.5.1 milestone Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (d4f7d68) to head (d340abf).

Files with missing lines Patch % Lines
panel/command/serve.py 0.00% 11 Missing ⚠️
panel/io/server.py 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d4f7d68) and HEAD (d340abf). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d4f7d68) HEAD (d340abf)
8 7
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7289       +/-   ##
===========================================
- Coverage   82.18%   71.78%   -10.40%     
===========================================
  Files         337      336        -1     
  Lines       50380    50393       +13     
===========================================
- Hits        41405    36176     -5229     
- Misses       8975    14217     +5242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 2e8597c into main Sep 20, 2024
15 checks passed
@philippjfr philippjfr deleted the setup_no_procs branch September 20, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants