Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show interval value on click #7064

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Show interval value on click #7064

merged 12 commits into from
Aug 14, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Aug 2, 2024

Adds CSS classes to the buttons + display value on speed increase

Screen.Recording.2024-08-02.at.2.58.33.PM.mov

Closes #5207

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (9404b43) to head (4863a31).

Files Patch % Lines
panel/tests/ui/widgets/test_player.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7064      +/-   ##
==========================================
+ Coverage   82.25%   82.27%   +0.01%     
==========================================
  Files         327      327              
  Lines       48784    48802      +18     
==========================================
+ Hits        40127    40150      +23     
+ Misses       8657     8652       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Just checking, but would showing fps rather than ms be clearer?

@ahuang11
Copy link
Contributor Author

ahuang11 commented Aug 5, 2024

I like that idea of using fps.

Screen.Recording.2024-08-05.at.11.18.14.AM.mov

panel/models/player.ts Outdated Show resolved Hide resolved
@ahuang11 ahuang11 requested a review from hoxbro August 6, 2024 22:01
panel/widgets/player.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit a3959ec into main Aug 14, 2024
16 checks passed
@philippjfr philippjfr deleted the display_player_interval branch August 14, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add speed values to Player widget
3 participants