Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable directory uploads with FileInput #6808

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Enable directory uploads with FileInput #6808

merged 9 commits into from
Jun 25, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 2, 2024

Adding the folder upload part mentioned in #6803

Also, an option to clear the FileInput from the Python side of things was added. I don't think it is the best way to do it.

TODO:

  • Add tests The logic have been moved directly into Bokeh.
  • Update documentation

@hoxbro hoxbro marked this pull request as draft May 3, 2024 03:52
@hoxbro hoxbro added this to the v1.5.0 milestone Jun 18, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (4e351ed) to head (65d8761).
Report is 3 commits behind head on main.

Files Patch % Lines
panel/reactive.py 61.53% 5 Missing ⚠️
panel/widgets/input.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6808      +/-   ##
==========================================
+ Coverage   81.16%   81.58%   +0.41%     
==========================================
  Files         323      323              
  Lines       47626    47664      +38     
==========================================
+ Hits        38658    38889     +231     
+ Misses       8968     8775     -193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro marked this pull request as ready for review June 25, 2024 11:45
@hoxbro hoxbro requested a review from philippjfr June 25, 2024 13:21
@philippjfr philippjfr merged commit 9cc1039 into main Jun 25, 2024
15 checks passed
@philippjfr philippjfr deleted the folder_input branch June 25, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants