Fix and improve Plotly event handling #6753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a ton of investigation I found that click event handling depends on the following sequence of events, which for some reason does not occur in the right sequence in our case (likely due to the shadow DOM):
In our case steps 2 and 3 were switched causing click events not to be dispatched. In this PR we do a few things:
<event_data>
bokeh properties into bokeh events, ensuring that the same event can be sent multiple times.Fixes #5096